| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Yaphters W <yaphters(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Rename 'lpp' to 'lp' in heapam.c |
| Date: | 2023-05-03 14:48:20 |
| Message-ID: | CA+TgmoYCWYP0Y4KfzpnOGJrSHwD5uR4ngRp9okEx0q6=gNwsDw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, May 2, 2023 at 10:18 PM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> I don't really agree that one is any more correct than the other. I
> also don't think we should be making changes like this as doing this
> may give some false impression that we have some standard to follow
> here that a local variable of a given type must be given a certain
> name. To comply with such a standard seems like it would take close to
> an endless number of patches which would just result in wasted
> reviewer and committer time and give us nothing but pain while back
> patching.
>
> -1 from me.
I agree with David. This seems like pointless code churn.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jonathan S. Katz | 2023-05-03 15:29:14 | Re: Move defaults toward ICU in 16? |
| Previous Message | Andrew Dunstan | 2023-05-03 13:20:28 | Re: issue with meson builds on msys2 |