From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Andres Freund <andres(at)anarazel(dot)de> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net> |
Subject: | Re: pgsql: Add 'basebackup_to_shell' contrib module. |
Date: | 2022-03-30 17:16:47 |
Message-ID: | CA+TgmoY7smOGpvcNJwzsK5Y4TyA-Wk=8dnRGjaDRqUOoGfUSTA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Wed, Mar 30, 2022 at 1:11 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> On March 30, 2022 9:58:26 AM PDT, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >Andres Freund <andres(at)anarazel(dot)de> writes:
> >> Random aside: Am I the only one bothered by a bunch of places in
> >> Makefile.global.in quoting like
> >> $(MAKE) -C '$(top_builddir)' DESTDIR='$(abs_top_builddir)'/tmp_install install >'$(abs_top_builddir)'/tmp_install/log/install.log 2>&1
> >> and
> >> rm -rf '$(CURDIR)'/tmp_check &&
> >> etc
> >
> >Don't we need that to handle, say, build paths with spaces in them?
>
> My concern is about the quote in the middle of the path, not about quoting at all... I.e. the ' should be after /tmp_install, not before.
Makes no difference. We know that the string /tmp_install contains no
shell metacharacters, so why does it need to be in quotes? I would've
probably written it the way it is here, rather than what you are
proposing.
--
Robert Haas
EDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Thomas Munro | 2022-03-30 18:07:21 | Re: pgsql: Add 'basebackup_to_shell' contrib module. |
Previous Message | Andres Freund | 2022-03-30 17:11:49 | Re: pgsql: Add 'basebackup_to_shell' contrib module. |
From | Date | Subject | |
---|---|---|---|
Next Message | Greg Stark | 2022-03-30 17:35:57 | Re: Add proper planner support for ORDER BY / DISTINCT aggregates |
Previous Message | Greg Stark | 2022-03-30 17:16:37 | Re: real/float example for testlibpq3 |