From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net> |
Subject: | Re: pgsql: Add 'basebackup_to_shell' contrib module. |
Date: | 2022-03-30 19:12:51 |
Message-ID: | 20220330191251.sgxjox64k3eteylb@alap3.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Hi,
On 2022-03-30 13:16:47 -0400, Robert Haas wrote:
> On Wed, Mar 30, 2022 at 1:11 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> > On March 30, 2022 9:58:26 AM PDT, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > >Andres Freund <andres(at)anarazel(dot)de> writes:
> > >> Random aside: Am I the only one bothered by a bunch of places in
> > >> Makefile.global.in quoting like
> > >> $(MAKE) -C '$(top_builddir)' DESTDIR='$(abs_top_builddir)'/tmp_install install >'$(abs_top_builddir)'/tmp_install/log/install.log 2>&1
> > >> and
> > >> rm -rf '$(CURDIR)'/tmp_check &&
> > >> etc
> > >
> > >Don't we need that to handle, say, build paths with spaces in them?
> >
> > My concern is about the quote in the middle of the path, not about quoting at all... I.e. the ' should be after /tmp_install, not before.
>
> Makes no difference. We know that the string /tmp_install contains no
> shell metacharacters, so why does it need to be in quotes? I would've
> probably written it the way it is here, rather than what you are
> proposing.
It looks ugly, and it can't be copy-pasted as easily. Seems I'm alone on this,
so I'll leave it be...
Greetings,
Andres Freund
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2022-03-30 19:19:48 | Re: pgsql: Add 'basebackup_to_shell' contrib module. |
Previous Message | Peter Eisentraut | 2022-03-30 18:27:57 | pgsql: Add range_agg with multirange inputs |
From | Date | Subject | |
---|---|---|---|
Next Message | Nathan Bossart | 2022-03-30 19:18:38 | Re: Patch to avoid orphaned dependencies |
Previous Message | Tom Lane | 2022-03-30 19:09:01 | Re: proposal: enhancing plpgsql debug API - returns text value of variable content |