| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Clarify use of temporary tables within partition trees |
| Date: | 2018-07-02 18:07:37 |
| Message-ID: | CA+TgmoY5EOxJSJCxH09rL1bpFHojpcAKyRym1Y=FiCpOv151mw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Fri, Jun 29, 2018 at 5:13 AM, David Rowley
<david(dot)rowley(at)2ndquadrant(dot)com> wrote:
> On 20 June 2018 at 13:53, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>> Clarify use of temporary tables within partition trees
>
> Thanks for committing this fix.
>
> I think slightly more should have been done. There's still some dead
> code in expand_partitioned_rtentry that I think should be removed.
>
> The code won't cost much performance wise, but it may mislead someone
> into thinking they can add some other condition there to skip
> partitions.
>
> The attached removes it.
I'd rather keep an elog(ERROR) than completely remove the check.
Also, for the record, I think the subject line of Michael's commit
message was pretty unclear about what it was actually doing.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-07-02 22:16:50 | Re: pgsql: Clarify use of temporary tables within partition trees |
| Previous Message | Alvaro Herrera | 2018-07-02 16:23:35 | Re: pgsql: Add wait event for fsync of WAL segments |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2018-07-02 18:18:41 | Re: alter index WITH ( storage_parameter = value [, ... ] ) for partition index. |
| Previous Message | Robert Haas | 2018-07-02 17:52:20 | Re: Regression on PostgreSQL 10 ORDER/GROUP BY expression not found in targetlist |