| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: tablespace_map code cleanup |
| Date: | 2020-05-13 19:10:30 |
| Message-ID: | CA+TgmoY479j90RA_DZ3z9wyR9E1j7ErM7g=etescFdx8Lehrtw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, May 12, 2020 at 10:26 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> I was trying to say that tablespace listing will happen under
> PROGRESS_BASEBACKUP_PHASE_WAIT_CHECKPOINT phase which could be a
> problem if it is a costly operation but as you said it is pretty cheap
> so I think we don't need to bother about that.
>
> Apart from the above point which I think we don't need to bother, both
> your patches look good to me.
OK, good. Let's see if anyone else feels differently about this issue
or wants to raise anything else. If not, I'll plan to commit these
patches after we branch. Thanks for the review.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2020-05-13 19:21:49 | Re: new heapcheck contrib module |
| Previous Message | Robert Haas | 2020-05-13 19:09:05 | Re: Parallel copy |