Re: pgAdmin 1.15 experiences

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Subject: Re: pgAdmin 1.15 experiences
Date: 2012-03-28 09:28:55
Message-ID: CA+OCxoz3B82cfusskXyPZzsemJH6i2cz-JecOVTYZ-0RtSwADg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

That looks OK to me - thanks. Guillaume, what do you think (it's fixing a
bug in your code :-) ). Basically the problem is in the code you added to
prevent the same properties dialogue being opened twice, or dropping of
objects that are open in dialogues. The issue was that the code always
assumed the selected item in the treeview was the item on which it was
acting, which is not always the case (for example, you might double-click
an item in the listview).

On Wed, Mar 28, 2012 at 10:25 AM, Akshay Joshi <
akshay(dot)joshi(at)enterprisedb(dot)com> wrote:

> Hi
>
> I am able to reproduce the bug as per the steps given by Wahlstedt Jyrki.
> I have tried to fix the crash and it is working for me. Attached is the
> patch file. Please review it. If solution looks good then please commit the
> code.
>
> On Wed, Mar 21, 2012 at 10:46 PM, Wahlstedt Jyrki <jwa(at)wahlstedt(dot)fi>wrote:
>
>>
>> On 15.3.2012, at 11.24, Akshay Joshi wrote:
>>
>>
>>
>> On Wed, Mar 14, 2012 at 10:20 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>> Akshay; could you investigate please?
>>
>>
>> Not able to reproduce the bug on OSX 10.6.8 with Postgres 9.0. I don't
>> have OSX version 10.7.3
>>
>>
>>
>> Hi,
>> I suppose I wasn't totally clear when showing how the crash occurred:
>> 1) I opened pgAdmin (obviously), and connected to server, then clicked on
>> 'Tables' in the left-hand pane.
>> 2) Then I double-clicked a table name in the right-hand pane (like
>> scoringsystem below).
>> 3) Then crash (the window for the table is created, but is all grey)
>>
>> This is just a check, I don't hope there is a crash, though it could make
>> debugging easier…
>>
>>
>> with best greetings,
>>
>> Jyrki Wahlstedt
>>
>>
>
>
> --
> *Akshay Joshi
> Senior Software Engineer
> EnterpriseDB Corporation
> The Enterprise PostgreSQL Company
> Phone: +91 20-3058-9522
> Mobile: +91 976-788-8246*
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Guillaume Lelarge 2012-03-29 18:32:47 pgAdmin website commit: Fix a URL
Previous Message Akshay Joshi 2012-03-28 09:25:14 Re: pgAdmin 1.15 experiences