| From: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
|---|---|
| To: | Dave Page <dpage(at)pgadmin(dot)org> |
| Cc: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgAdmin 1.15 experiences |
| Date: | 2012-03-29 19:39:09 |
| Message-ID: | 1333049949.2335.3.camel@localhost.localdomain |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
On Wed, 2012-03-28 at 10:28 +0100, Dave Page wrote:
> That looks OK to me - thanks. Guillaume, what do you think (it's
> fixing a bug in your code :-) ). Basically the problem is in the code
> you added to prevent the same properties dialogue being opened twice,
> or dropping of objects that are open in dialogues. The issue was that
> the code always assumed the selected item in the treeview was the item
> on which it was acting, which is not always the case (for example, you
> might double-click an item in the listview).
>
It seems good to me. I don't reproduce the bug, so I can't say if this
specific patch fixed it. But the patch seems good.
--
Guillaume
http://blog.guillaume.lelarge.info
http://www.dalibo.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | pgAdmin Trac | 2012-03-29 19:43:41 | [pgAdmin III] #358: Allow to set option is_called for setval Date: Tue, 27 Mar 2012 08:58:32 +0200 |
| Previous Message | Guillaume Lelarge | 2012-03-29 18:32:47 | pgAdmin website commit: Fix a URL |