| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][Patch]: To fix Indentation issue in query tool |
| Date: | 2017-10-16 08:44:27 |
| Message-ID: | CA+OCxoxp5NJshskVOdUkMjBx39HGwA50xqEH+o1B=_2iukVeUw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi
On Mon, Oct 16, 2017 at 5:43 AM, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Hi,
>
> PFA patch to fix the issue where indentation is not working as expected,
> when user opt for tab based indentation instead of space based indentation.
> RM#2780
>
Shouldn't we just use the use_spaces option here? I don't see any reason
why pressing tab vs. an auto-indent should be any different.
As a sidenote, in sqleditor/__init__.py, both config options are being
defined as "self.use_spaces = ..."
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Murtuza Zabuawala | 2017-10-16 12:21:24 | Re: [pgAdmin4][Patch]: To fix Indentation issue in query tool |
| Previous Message | Dave Page | 2017-10-16 08:21:13 | Re: [pgAdmin4][Patch]: Use https:// to open postgres online help documents |