| From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Tender Wang <tndrwang(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, exclusion(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #18657: Using JSON_OBJECTAGG with volatile function leads to segfault |
| Date: | 2024-10-20 03:41:47 |
| Message-ID: | CA+HiwqHSiGf94-r5Z0ezJebufUDzp6m6NTkpo6NV23ryew__Nw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Sun, Oct 20, 2024 at 1:05 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Amit Langote <amitlangote09(at)gmail(dot)com> writes:
> > Updated patch attached.
>
> v8 is OK by me. Personally I would not bother with the Asserts
> that raw_expr/formatted_expr are not null, in either place;
> the code doesn't actually depend on that, and IMO it's inconsistent
> with the style of surrounding code. But that's not a hill to die on.
Pushed after removing the Assert and tweaking the commit message a bit.
Thanks a lot for looking at this.
--
Thanks, Amit Langote
| From | Date | Subject | |
|---|---|---|---|
| Next Message | PG Bug reporting form | 2024-10-20 19:00:01 | BUG #18664: Assert in BeginCopyTo() fails when source DML query rewritten with notifying rule |
| Previous Message | Tom Lane | 2024-10-19 23:48:35 | Re: BUG #18545: \dt breaks transaction, calling error when executed in SET SESSION AUTHORIZATION |