Re: Run-time pruning for ModifyTable

From: Amit Langote <amitlangote09(at)gmail(dot)com>
To: "Kato, Sho" <kato-sho(at)jp(dot)fujitsu(dot)com>
Cc: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Run-time pruning for ModifyTable
Date: 2019-07-08 02:33:56
Message-ID: CA+HiwqHFG4US0Y1m=WQeExBfXAP-PxaWkRObNpxoLMQ3jUxd1A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Kato-san,

On Thu, Jul 4, 2019 at 1:40 PM Kato, Sho <kato-sho(at)jp(dot)fujitsu(dot)com> wrote:
> > If I understand the details of [1] correctly, ModifyTable will no longer
> > have N subplans for N result relations as there are today. So, it doesn't
> > make sense for ModifyTable to contain PartitionedRelPruneInfos and for
> > ExecInitModifyTable/ExecModifyTable
> > to have to perform initial and execution-time pruning, respectively.
>
> Does this mean that the generic plan will not have N subplans for N result relations?
> I thought [1] would make creating generic plans faster, but is this correct?

Yeah, making a generic plan for UPDATE of inheritance tables will
certainly become faster, because we will no longer plan the same query
N times for N child tables. There will still be N result relations
but only one sub-plan to fetch the rows from. Also, planning will
still cost O(N), but with a much smaller constant factor.

By the way, let's keep any further discussion on this particular topic
in the other thread.

Thanks,
Amit

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ryan Lambert 2019-07-08 02:35:29 Re: FETCH FIRST clause PERCENT option
Previous Message Amit Langote 2019-07-08 02:07:35 Re: Another way to fix inherited UPDATE/DELETE