Re: duplicate line in ExecEvalJsonCoercionFinish

From: Amit Langote <amitlangote09(at)gmail(dot)com>
To: Richard Guo <guofenglinux(at)gmail(dot)com>
Cc: Tender Wang <tndrwang(at)gmail(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: duplicate line in ExecEvalJsonCoercionFinish
Date: 2025-07-17 06:11:04
Message-ID: CA+HiwqGef+RQYF+9au37faCyEXNA4sfoCkHpH9wb_yRQEcvjcw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jul 17, 2025 at 12:03 PM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> On Thu, Jul 17, 2025 at 10:01 AM Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
> > On Thu, Jul 17, 2025 at 9:52 AM Tender Wang <tndrwang(at)gmail(dot)com> wrote:
> > > jian he <jian(dot)universality(at)gmail(dot)com> 于2025年7月17日周四 07:39写道:
> > >> ExecEvalJsonCoercionFinish duplicate line:
> > >> jsestate->escontext.error_occurred = false;
> > >> jsestate->escontext.error_occurred = false;
> >
> > > Good catch. It was introduced by this commit 231b7d670b21.
> > > Add Amit to the cc list.
> >
> > Nice catch! The two duplicate statements were introduced in separate
> > commits; looks like a copy-paste oversight in the later one.
>
> Oops, you're right -- I must have copy-pasted without noticing the
> duplicate. Thanks Jian for catching that. Will fix.

Done. Thanks all.

--
Thanks, Amit Langote

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Laurenz Albe 2025-07-17 06:16:43 Re: Fix PQport to never return NULL if the connection is valid
Previous Message Álvaro Herrera 2025-07-17 05:47:52 Re: Log prefix missing for subscriber log messages received from publisher