Re: duplicate line in ExecEvalJsonCoercionFinish

From: Amit Langote <amitlangote09(at)gmail(dot)com>
To: Richard Guo <guofenglinux(at)gmail(dot)com>
Cc: Tender Wang <tndrwang(at)gmail(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: duplicate line in ExecEvalJsonCoercionFinish
Date: 2025-07-17 03:03:14
Message-ID: CA+HiwqFyNEdGfNeT8Fq4BToKW7D0NDzQHkDWjw+gE0Ku8QfqCw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jul 17, 2025 at 10:01 AM Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
> On Thu, Jul 17, 2025 at 9:52 AM Tender Wang <tndrwang(at)gmail(dot)com> wrote:
> > jian he <jian(dot)universality(at)gmail(dot)com> 于2025年7月17日周四 07:39写道:
> >> ExecEvalJsonCoercionFinish duplicate line:
> >> jsestate->escontext.error_occurred = false;
> >> jsestate->escontext.error_occurred = false;
>
> > Good catch. It was introduced by this commit 231b7d670b21.
> > Add Amit to the cc list.
>
> Nice catch! The two duplicate statements were introduced in separate
> commits; looks like a copy-paste oversight in the later one.

Oops, you're right -- I must have copy-pasted without noticing the
duplicate. Thanks Jian for catching that. Will fix.

--
Thanks, Amit Langote

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Smith 2025-07-17 03:22:17 Re: [WIP]Vertical Clustered Index (columnar store extension) - take2
Previous Message David Rowley 2025-07-17 03:01:55 Re: simple patch for discussion