Re: BUG #15629: Typo in Documentation

From: Amit Langote <amitlangote09(at)gmail(dot)com>
To: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
Cc: syluo1990(at)hotmail(dot)com, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org>
Subject: Re: BUG #15629: Typo in Documentation
Date: 2019-02-11 13:18:56
Message-ID: CA+HiwqG94pwK2uMo=CvewW82Y1D1q5qiP0nGm0wROqXNi+LDKw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Mon, Feb 11, 2019 at 5:25 PM David Rowley
<david(dot)rowley(at)2ndquadrant(dot)com> wrote:
> On Mon, 11 Feb 2019 at 20:49, PG Bug reporting form
> <noreply(at)postgresql(dot)org> wrote:
> > https://www.postgresql.org/docs/current/ddl-partitioning.html
> >
> > 5.10.5. Partitioning and Constraint Exclusion
> > Constraint exclusion is only applied during query planning; unlike partition
> > pruning, it cannot be applied during query execution.
> >
> > Is it supposed to be "unlike partition pruning, it can be applied during
> > query execution"?
>
> That's a bit confusing. "it" looks like must have been intended to
> reference constraint exclusion, but since partition pruning was
> mentioned afterwards, then it makes more sense to apply it to that.
>
> Maybe it would be more clear to write:
>
> Constraint exclusion is only applied during query planning; unlike
> partition pruning which can also be applied during query execution.
>
> Small patch doing it that way is attached.

+1

Maybe, the semicolon should be replaced by a comma?

Thanks,
Amit

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message PG Bug reporting form 2019-02-11 17:43:13 BUG #15631: Generated as identity field in a temporary table with on commit drop corrupts system catalogs
Previous Message PG Bug reporting form 2019-02-11 10:35:54 BUG #15630: Caused by: com.ibm.ws.extensionhelper.exception.UnknownDatabaseException: Could not detect database

Browse pgsql-hackers by date

  From Date Subject
Next Message Evgeniy Efimkin 2019-02-11 13:30:22 Re: [WIP] CREATE SUBSCRIPTION with FOR TABLES clause (table filter)
Previous Message Michael Paquier 2019-02-11 12:53:59 Re: Add missing CREATE TABLE IF NOT EXISTS table_name AS EXECUTE query;