| From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
|---|---|
| To: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> |
| Cc: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Shohei Mochizuki <shohei(dot)mochizuki(at)toshiba(dot)co(dot)jp>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: BEFORE UPDATE trigger on postgres_fdw table not work |
| Date: | 2019-06-12 06:33:35 |
| Message-ID: | CA+HiwqG0RpHo5wV+owGX9WCONE81EpOtJWzaPcvMiaYwPmZPBA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Fujita-san,
On Wed, Jun 12, 2019 at 3:14 PM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
> I did that, but couldn't find any issue about the patch. Here is an
> updated version of the patch.
Thanks for the updating the patch.
> Changes are:
>
> * Reworded the comments a bit in postgresPlanFoereignModify the
> original patch modified
+ * statement, and for UPDATE if BEFORE ROW UPDATE triggers since those
+ * triggers might change values for non-target columns, in which case we
First line seems to be missing a word or two. Maybe:
+ * statement, and for UPDATE if there are BEFORE ROW UPDATE triggers,
+ * since those triggers might change values for non-target columns, in
Thanks,
Amit
| From | Date | Subject | |
|---|---|---|---|
| Next Message | legrand legrand | 2019-06-12 07:08:38 | Re: Adaptive query optimization |
| Previous Message | Heikki Linnakangas | 2019-06-12 06:31:39 | Re: pgbench rate limiting changes transaction latency computation |