| From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Amit Langote <amitlan(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Remove obsolete executor cleanup code |
| Date: | 2023-09-28 02:04:08 |
| Message-ID: | CA+HiwqFq6LDWg1y__ntqJ3my28jgHtP4McPBw3FMghSFYyvF8w@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Thu, Sep 28, 2023 at 10:08 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Amit Langote <amitlan(at)postgresql(dot)org> writes:
> > After these modifications, the ExecEnd*() routines for ValuesScan,
> > NamedTuplestoreScan, and WorkTableScan became redundant. So, this
> > commit removes them.
>
> This seems like quite a bad idea. From a documentation standpoint
> alone, it would be far better for these functions to exist but be
> empty.
Actually, the documentation aspect of this change does bother me a
bit, but I also agree with Robert's preference to remove such empty
functions altogether to shave some albeit few CPU cycles off [1].
I am fine with reverting this part if you insist though.
--
Thanks, Amit Langote
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2023-09-28 06:18:26 | pgsql: Show parameters of CALL as constants in pg_stat_statements |
| Previous Message | Tom Lane | 2023-09-28 01:08:36 | Re: pgsql: Remove obsolete executor cleanup code |