Re: pgsql: Remove obsolete executor cleanup code

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Amit Langote <amitlan(at)postgresql(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Remove obsolete executor cleanup code
Date: 2023-09-28 01:08:36
Message-ID: 802307.1695863316@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Amit Langote <amitlan(at)postgresql(dot)org> writes:
> After these modifications, the ExecEnd*() routines for ValuesScan,
> NamedTuplestoreScan, and WorkTableScan became redundant. So, this
> commit removes them.

This seems like quite a bad idea. From a documentation standpoint
alone, it would be far better for these functions to exist but be
empty.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Langote 2023-09-28 02:04:08 Re: pgsql: Remove obsolete executor cleanup code
Previous Message Amit Langote 2023-09-28 01:02:07 pgsql: Remove obsolete executor cleanup code