Re: Reject invalid databases in pg_get_database_ddl()

From: Amit Langote <amitlangote09(at)gmail(dot)com>
To: Euler Taveira <euler(at)eulerto(dot)com>
Cc: Lakshmi N <lakshmin(dot)jhs(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: Reject invalid databases in pg_get_database_ddl()
Date: 2026-04-17 02:15:39
Message-ID: CA+HiwqFenEgD4W1QWnHM0whbzWYH=uS6qQzxvKNH7z503HWvxw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Apr 17, 2026 at 10:47 AM Euler Taveira <euler(at)eulerto(dot)com> wrote:
> On Thu, Apr 16, 2026, at 8:46 PM, Amit Langote wrote:
> >
> > Thanks. Will push the attached shortly.
>
> I think the errhint() is excessive in this context. It makes sense if you are
> executing ALTER DATABASE, for example.

Yeah, agreed.

> I suggest a message like
>
> database \"%s\" is an invalid database

Or just drop it, because the errmsg already says "invalid database %s".

> Regarding the test case suggested by Japin Li, I don't think it is worth because
> it is a transient state (unless something bad happened and pg_database contains
> a dangling row.)

Agreed.

Patch updated.

--
Thanks, Amit Langote

Attachment Content-Type Size
v3-0001-Reject-invalid-databases-in-pg_get_database_ddl.patch application/octet-stream 1.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Japin Li 2026-04-17 02:30:44 Re: Reject invalid databases in pg_get_database_ddl()
Previous Message Mihail Nikalayeu 2026-04-17 02:01:00 Re: Adding REPACK [concurrently]