| From: | "Euler Taveira" <euler(at)eulerto(dot)com> |
|---|---|
| To: | "Amit Langote" <amitlangote09(at)gmail(dot)com>, "Lakshmi N" <lakshmin(dot)jhs(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "Andrew Dunstan" <andrew(at)dunslane(dot)net> |
| Subject: | Re: Reject invalid databases in pg_get_database_ddl() |
| Date: | 2026-04-17 01:46:51 |
| Message-ID: | 976a432b-9221-4825-8e8f-41f4375737fe@app.fastmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Apr 16, 2026, at 8:46 PM, Amit Langote wrote:
>
> Thanks. Will push the attached shortly.
>
I think the errhint() is excessive in this context. It makes sense if you are
executing ALTER DATABASE, for example. I suggest a message like
database \"%s\" is an invalid database
Regarding the test case suggested by Japin Li, I don't think it is worth because
it is a transient state (unless something bad happened and pg_database contains
a dangling row.)
--
Euler Taveira
EDB https://www.enterprisedb.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hayato Kuroda (Fujitsu) | 2026-04-17 01:58:18 | RE: [doc] pg_ctl: fix wrong description for -l |
| Previous Message | Japin Li | 2026-04-17 01:40:07 | Re: Reject invalid databases in pg_get_database_ddl() |