| From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Nikolay Shaplov <dhyan(at)nataraj(dot)su>, Dent John <denty(at)qqdd(dot)eu>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "Iwata, Aya" <iwata(dot)aya(at)jp(dot)fujitsu(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Do not use StdRdOptions in Access Methods |
| Date: | 2019-11-07 01:49:38 |
| Message-ID: | CA+HiwqE6zbNO92az6pp5GiTw4tr-9rfCE0t84whQSP+YwSKjMQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Nov 5, 2019 at 9:22 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Thu, Oct 31, 2019 at 05:55:55PM +0900, Michael Paquier wrote:
> > Thanks. I exactly did the same thing on my local branch.
>
> Hearing nothing more, I have done some adjustments to the patch and
> committed it.
Thank you.
> Please note that I have not switched the old interface
> to be static to reloptions.c as if you look closely at reloptions.h we
> allow much more flexibility around HANDLE_INT_RELOPTION to fill and
> parse the reloptions in custom AM. AM maintainers had better use the
> new interface, but there could be a point for more customized error
> messages.
I looked around but don't understand why these macros need to be
exposed. I read this comment:
* Note that this is more or less the same that fillRelOptions does, so only
* use this if you need to do something non-standard within some option's
* code block.
but don't see how an AM author might be able to do something
non-standard with this interface.
Maybe Alvaro knows this better.
Thanks,
Amit
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-11-07 01:54:29 | Re: [PATCH] Do not use StdRdOptions in Access Methods |
| Previous Message | Michael Paquier | 2019-11-07 01:39:42 | Re: SKIP_LOCKED test causes random buildfarm failures |