| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Amit Langote <amitlangote09(at)gmail(dot)com> |
| Cc: | Nikolay Shaplov <dhyan(at)nataraj(dot)su>, Dent John <denty(at)qqdd(dot)eu>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "Iwata, Aya" <iwata(dot)aya(at)jp(dot)fujitsu(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Do not use StdRdOptions in Access Methods |
| Date: | 2019-11-07 01:54:29 |
| Message-ID: | 20191107015429.GB1768@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Nov 07, 2019 at 10:49:38AM +0900, Amit Langote wrote:
> I looked around but don't understand why these macros need to be
> exposed. I read this comment:
>
> * Note that this is more or less the same that fillRelOptions does, so only
> * use this if you need to do something non-standard within some option's
> * code block.
>
> but don't see how an AM author might be able to do something
> non-standard with this interface.
>
> Maybe Alvaro knows this better.
Perhaps there is a point in cleaning up all that more, but I am not
sure that it is worth potentially breaking other people's code.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2019-11-07 01:58:51 | Re: [PATCH] Do not use StdRdOptions in Access Methods |
| Previous Message | Amit Langote | 2019-11-07 01:49:38 | Re: [PATCH] Do not use StdRdOptions in Access Methods |