| From: | Rafia Sabih <rafia(dot)pghackers(at)gmail(dot)com> |
|---|---|
| To: | Aleksander Alekseev <aleksander(at)tigerdata(dot)com> |
| Cc: | PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Add tests for src/backend/nodes/extensible.c |
| Date: | 2026-08-05 05:49:14 |
| Message-ID: | CA+FpmFfUMovM7XPrAh69CsBxm6=TdTjR_NKx_TUU+ys0cCn18w@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 30 Jul 2026 at 18:21, Aleksander Alekseev <aleksander(at)tigerdata(dot)com>
wrote:
> Hi Rafia,
>
> > I looked into this patch and have a few comments.
> > Firstly, in test_create_custom_scan_state() why hard coding css.slotOps
> = &TTSOpsBufferHeapTuple and not using the table_slot_callbacks() for the
> purpose and getting the real AM.
> > Next, in test_plan_custom_path, the last two arguments are never used.
> > There are no tests for nodeCopy, nodeEqual, nodeOut, and nodeRead
> routines.
>
> Many thanks for the feedback! Here is the corrected patch.
>
> Thanks. There is a typo in the current patch --... the CustomScanStateand
and is expected
Other than that it looks good to me.
--
Regards,
Rafia Sabih
CYBERTEC PostgreSQL International GmbH
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chao Li | 2026-08-05 05:52:36 | Re: Avoid building stderr message if possible |
| Previous Message | Zhijie Hou (Fujitsu) | 2026-08-05 05:25:04 | RE: [bug fix] prepared transaction might be lost when max_prepared_transactions is zero on the subscriber |