| From: | Aleksander Alekseev <aleksander(at)tigerdata(dot)com> |
|---|---|
| To: | PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Rafia Sabih <rafia(dot)pghackers(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Add tests for src/backend/nodes/extensible.c |
| Date: | 2026-07-30 12:50:54 |
| Message-ID: | CAJ7c6TMby8Nd9s6_jA3t_Yiay7C8OYx6c-=zrSVXnmXUoPzkMQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Rafia,
> I looked into this patch and have a few comments.
> Firstly, in test_create_custom_scan_state() why hard coding css.slotOps = &TTSOpsBufferHeapTuple and not using the table_slot_callbacks() for the purpose and getting the real AM.
> Next, in test_plan_custom_path, the last two arguments are never used.
> There are no tests for nodeCopy, nodeEqual, nodeOut, and nodeRead routines.
Many thanks for the feedback! Here is the corrected patch.
--
Best regards,
Aleksander Alekseev
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Add-test-module-for-src-backend-nodes-extensible..patch | text/x-patch | 30.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Shlok Kyal | 2026-07-30 12:53:04 | Re: Support EXCEPT for ALL SEQUENCES publications |
| Previous Message | Shlok Kyal | 2026-07-30 12:49:57 | Re: Support EXCEPT for ALL SEQUENCES publications |