| From: | "Amonson, Paul D" <paul(dot)d(dot)amonson(at)intel(dot)com> |
|---|---|
| To: | "Amonson, Paul D" <paul(dot)d(dot)amonson(at)intel(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, David Rowley <dgrowleyml(at)gmail(dot)com>, "Andres Freund" <andres(at)anarazel(dot)de>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, "Shankaran, Akash" <akash(dot)shankaran(at)intel(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: Popcount optimization using AVX512 |
| Date: | 2024-03-28 22:29:47 |
| Message-ID: | BL1PR11MB5304217FFEFB15124CD2EC9EDC3B2@BL1PR11MB5304.namprd11.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> -----Original Message-----
> From: Amonson, Paul D <paul(dot)d(dot)amonson(at)intel(dot)com>
> Sent: Thursday, March 28, 2024 3:03 PM
> To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
> ...
> I will review the new patch to see if there are anything that jumps out at me.
I see in the meson.build you added the new file twice?
@@ -7,6 +7,7 @@ pgport_sources = [
'noblock.c',
'path.c',
'pg_bitutils.c',
+ 'pg_popcount_avx512.c',
'pg_strong_random.c',
'pgcheckdir.c',
'pgmkdirp.c',
@@ -84,6 +85,7 @@ replace_funcs_pos = [
['pg_crc32c_sse42', 'USE_SSE42_CRC32C_WITH_RUNTIME_CHECK', 'crc'],
['pg_crc32c_sse42_choose', 'USE_SSE42_CRC32C_WITH_RUNTIME_CHECK'],
['pg_crc32c_sb8', 'USE_SSE42_CRC32C_WITH_RUNTIME_CHECK'],
+ ['pg_popcount_avx512', 'USE_AVX512_POPCNT_WITH_RUNTIME_CHECK', 'avx512_popcnt'],
I was putting the file with special flags ONLY in the second section and all seemed to work. :)
Everything else seems good to me.
Thanks,
Paul
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2024-03-28 22:34:02 | Re: [PoC] Federated Authn/z with OAUTHBEARER |
| Previous Message | Alvaro Herrera | 2024-03-28 22:10:33 | Re: Popcount optimization using AVX512 |