Re: Fix out-of-date comment on makeRangeConstructors

From: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
To: Paul A Jungwirth <pj(at)illuminatedcomputing(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fix out-of-date comment on makeRangeConstructors
Date: 2025-12-05 02:26:19
Message-ID: BD069182-C88B-4870-85F3-0FDB56FDBF51@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Dec 5, 2025, at 06:34, Paul A Jungwirth <pj(at)illuminatedcomputing(dot)com> wrote:
>
> Hi Hackers,
>
> I noticed that makeRangeConstructors (in commands/typecmds.c) says:
>
>> We actually define 4 functions, with 0 through 3 arguments.
>
> But that hasn't been true since 2011 (df73584431). We only have 2-arg
> and 3-arg functions. Here is a quick patch to update the comment.
>
> Yours,
>
> --
> Paul ~{:-)
> pj(at)illuminatedcomputing(dot)com
> <v1-0001-Fix-out-of-date-comment-on-makeRangeConstructors.patch>

I think the fix is reasonable, which reflects to the current code:

```
static const char *const prosrc[2] = {"range_constructor2",
"range_constructor3"};
static const int pronargs[2] = {2, 3};
```

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2025-12-05 02:29:50 Re: Extended Statistics set/restore/clear functions.
Previous Message Michael Paquier 2025-12-05 02:23:31 Re: change default default_toast_compression to lz4?