Re: Fix out-of-date comment on makeRangeConstructors

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Paul A Jungwirth <pj(at)illuminatedcomputing(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fix out-of-date comment on makeRangeConstructors
Date: 2025-12-13 15:57:36
Message-ID: 038e1ff6-2186-4d75-b150-d995fe1aa315@eisentraut.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 05.12.25 03:26, Chao Li wrote:
>> On Dec 5, 2025, at 06:34, Paul A Jungwirth <pj(at)illuminatedcomputing(dot)com> wrote:
>> I noticed that makeRangeConstructors (in commands/typecmds.c) says:
>>
>>> We actually define 4 functions, with 0 through 3 arguments.
>>
>> But that hasn't been true since 2011 (df73584431). We only have 2-arg
>> and 3-arg functions. Here is a quick patch to update the comment.
>
> I think the fix is reasonable, which reflects to the current code:
>
> ```
> static const char *const prosrc[2] = {"range_constructor2",
> "range_constructor3"};
> static const int pronargs[2] = {2, 3};
> ```

committed

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2025-12-13 16:08:07 Re: Proposal: Add a callback data parameter to GetNamedDSMSegment
Previous Message Tom Lane 2025-12-13 15:54:33 Re: Making jsonb_agg() faster