Re: [PATCHES] Generic Monitoring Framework with DTrace

From: korry <korryd(at)enterprisedb(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCHES] Generic Monitoring Framework with DTrace
Date: 2006-07-21 14:37:08
Message-ID: BAY101-DAV3851B07E2C52CCDC9FB03D6660@phx.gbl
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches


>> On Fri, Jul 21, 2006 at 01:42:26PM +0200, Peter Eisentraut wrote:
>>
>>> I would prefer to drop the PG_ prefixes on PG_TRACE and pg_trace.h. We
>>> know which software we're dealing with.
>>>
>
>
>> I don't know. "trace" is a fairly generic word, how do you know that
>> none of the dozen other libraries we include don't already have a
>> "trace.h" or a TRACE() macro? On any of our supported platforms?
>>
>
> I concur with Martijn. We've already regretted using ERROR as a macro
> name, let's not make the same mistake with TRACE. PG_TRACE is good,
> and so is pg_trace.h. (But invoking it as utils/trace.h would be ok.)
>
>
How about the obvious DTRACE( .... ) or some similar variant?

-- Korry

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Sven Geisler 2006-07-21 14:59:49 Re: [HACKERS] Sun Donated a Sun Fire T2000 to the PostgreSQL
Previous Message Tom Lane 2006-07-21 14:30:13 Re: [PATCHES] Generic Monitoring Framework with DTrace patch

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2006-07-21 15:03:05 Re: [PATCHES] Generic Monitoring Framework with DTrace
Previous Message Tom Lane 2006-07-21 14:30:13 Re: [PATCHES] Generic Monitoring Framework with DTrace patch