| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Martijn van Oosterhout <kleptog(at)svana(dot)org> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org, Robert Lor <Robert(dot)Lor(at)sun(dot)com> |
| Subject: | Re: [PATCHES] Generic Monitoring Framework with DTrace patch |
| Date: | 2006-07-21 14:30:13 |
| Message-ID: | 22369.1153492213@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Martijn van Oosterhout <kleptog(at)svana(dot)org> writes:
> On Fri, Jul 21, 2006 at 01:42:26PM +0200, Peter Eisentraut wrote:
>> I would prefer to drop the PG_ prefixes on PG_TRACE and pg_trace.h. We
>> know which software we're dealing with.
> I don't know. "trace" is a fairly generic word, how do you know that
> none of the dozen other libraries we include don't already have a
> "trace.h" or a TRACE() macro? On any of our supported platforms?
I concur with Martijn. We've already regretted using ERROR as a macro
name, let's not make the same mistake with TRACE. PG_TRACE is good,
and so is pg_trace.h. (But invoking it as utils/trace.h would be ok.)
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | korry | 2006-07-21 14:37:08 | Re: [PATCHES] Generic Monitoring Framework with DTrace |
| Previous Message | Dave Page | 2006-07-21 14:23:27 | Re: BF Failure on Bandicoot |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | korry | 2006-07-21 14:37:08 | Re: [PATCHES] Generic Monitoring Framework with DTrace |
| Previous Message | Dave Page | 2006-07-21 14:23:27 | Re: BF Failure on Bandicoot |