Re: adding a new column in IDENTIFY_SYSTEM

On Tue, May 24, 2011 at 22:31, Jaime Casanova <jaime(at)2ndquadrant(dot)com> wrote:
> On Tue, May 24, 2011 at 8:52 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>
>> +       primary_xlp_magic = atoi(PQgetvalue(res, 0, 2));
>>
>> You wrongly get the third field (i.e., current xlog location) as the
>> WAL version.
>> You should call PQgetvalue(res, 0, 3), instead.
>>
>>> errdetail("Expected 1 tuple with 3 fields, got %d tuples with %d fields.",
>>
>> You need to change the above message.
>>
>
> Fixed.
>
> About you comments on the check... if you read the thread, you will
> find that the whole reason for the field is future improvement, but
> everyone wanted some use of the field now... so i made a patch to use
> it in pg_basebackup before the transfer starts and avoid time and
> bandwith waste but Magnus prefer this in walreceiver...

The idea *at this point* was, I believe, to be able to provide a more
useful error message in the case of walreceiver.

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/