| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | Florents Tselai <florents(dot)tselai(at)gmail(dot)com> |
| Cc: | Nathan Bossart <nathandbossart(at)gmail(dot)com>, Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, Lauri Siltanen <lauri(dot)siltanen(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Feature: psql - display current search_path in prompt |
| Date: | 2025-10-25 07:57:11 |
| Message-ID: | B7F5001F-D273-4B85-96A4-C7E3BDE069BB@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Oct 25, 2025, at 12:38, Florents Tselai <florents(dot)tselai(at)gmail(dot)com> wrote:
>
> <v3-0001-psql-Add-S-prompt-escape-to-display-current-searc.patch>
Overall LGTM. Just one comment:
```
+ /* current search_path, or "?" if not reported by the server */
+ case 'S':
+ strlcpy(buf, session_search_path(), sizeof(buf));
+ break;
```
I guess we also need to update the function comment to add a description for “%S”.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dean Rasheed | 2025-10-25 10:33:49 | Re: Improving and extending int128.h to more of numeric.c |
| Previous Message | Amit Kapila | 2025-10-25 06:56:55 | Re: Logical Replication of sequences |