| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Euler Taveira <euler(at)eulerto(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org> |
| Subject: | Re: Logical Replication of sequences |
| Date: | 2025-10-25 06:56:55 |
| Message-ID: | CAA4eK1JC6vFr_3+t_cFAHXjNBrPyBNQQZxpD7BTduwq4s9BQfw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Oct 24, 2025 at 8:52 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> On Thu, 23 Oct 2025 at 16:47, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > On Thu, Oct 23, 2025 at 11:45 AM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> > >
> > > The attached patch has the changes for the same.
> > >
> >
> > I have pushed 0001 and the following are comments on 0002.
> >
> > 1.
> > @@ -1414,6 +1414,7 @@ CREATE VIEW pg_stat_subscription_stats AS
> > ss.subid,
> > s.subname,
> > ss.apply_error_count,
> > + ss.sequence_sync_error_count,
> > ss.sync_error_count,
> >
> > The new parameter name is noticeably longer than other columns. Can we
> > name it as ss.seq_sync_error_count. We may also want to reconsider
> > changing existing column sync_error_count to tbl_sync_error_count. Can
> > we extract this in a separate stats patch?
>
> Modified and extracted a separate patch for tbl_sync_error_count
>
Hmm, I didn't want to make the stats related changes before the main
patch. I suggested to extract seq_sync_error_count from the main patch
and keep it after the main patch. Along with the seq_sync_error_count
stats, we can discuss whether to change existing parameter to
tbl_sync_error_count.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chao Li | 2025-10-25 07:57:11 | Re: Feature: psql - display current search_path in prompt |
| Previous Message | Amit Kapila | 2025-10-25 06:45:55 | Re: Logical Replication of sequences |