Re: pgindent vs dtrace on macos

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgindent vs dtrace on macos
Date: 2020-09-22 08:25:54
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

> On 21 Sep 2020, at 20:55, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Oh wait, I forgot about the fmgrprotos.h discrepancy.
> I wrote:
>> It strikes me that a low-cost workaround would be to rename these
>> C functions. There's no law that their C names must match the
>> SQL names.
> Here's a proposed patch to fix it that way.

+1 on this patch. Do you think it's worth adding a note about this in the
documentation to save the next one staring at this a few minutes? Something
along the lines of:

--- a/src/tools/pgindent/README
+++ b/src/tools/pgindent/README
@@ -110,6 +110,9 @@ Sometimes, if pgindent or perltidy produces odd-looking output, it's because
of minor bugs like extra commas. Don't hesitate to clean that up while
you're at it.

+If an exported function shares a name with a typedef, the header file with the
+prototype can get incorrect spacing for the function.

cheers ./daniel

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Hou, Zhijie 2020-09-22 08:33:48 RE: Use appendStringInfoString and appendPQExpBufferStr where possible
Previous Message Andrey Lepikhov 2020-09-22 07:41:11 Re: Global snapshots