| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgindent vs dtrace on macos |
| Date: | 2020-09-22 14:18:40 |
| Message-ID: | 1177223.1600784320@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
>> On 21 Sep 2020, at 20:55, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Here's a proposed patch to fix it that way.
> +1 on this patch. Do you think it's worth adding a note about this in the
> documentation to save the next one staring at this a few minutes? Something
> along the lines of:
> +If an exported function shares a name with a typedef, the header file with the
> +prototype can get incorrect spacing for the function.
AFAIK, a function name that's the same as a typedef name will get
misformatted whether it's exported or not; pgindent doesn't really
know the difference. But yeah, we could add something about this.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Banck | 2020-09-22 14:26:31 | Re: [patch] Fix checksum verification in base backups for zero page headers |
| Previous Message | Konstantin Knizhnik | 2020-09-22 13:40:11 | Re: Asynchronous Append on postgres_fdw nodes. |