Re: meson: pkgconfig difference

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: meson: pkgconfig difference
Date: 2023-02-01 07:55:46
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


On January 31, 2023 11:40:52 PM PST, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> wrote:
>I think there is a tiny typo in src/interfaces/ecpg/ecpglib/
>diff --git a/src/interfaces/ecpg/ecpglib/ b/src/interfaces/ecpg/ecpglib/
>index dba9e3c3d9..da8d304f54 100644
>--- a/src/interfaces/ecpg/ecpglib/
>+++ b/src/interfaces/ecpg/ecpglib/
>@@ -57,7 +57,7 @@ pkgconfig.generate(
> description: 'PostgreSQL libecpg library',
> url: pg_url,
> libraries: ecpglib_so,
>- libraries_private: [frontend_shlib_code, thread_dep],
>+ libraries_private: [frontend_stlib_code, thread_dep],
> requires_private: ['libpgtypes', 'libpq'],
> )
>This makes it match the other libraries.
>Without this change, we get
>Libs.private: ... -lpgport_shlib -lpgcommon_shlib
>which seems wrong.

Ugh, yes, that's wrong. Do you want me to apply the fix?



Sent from my Android device with K-9 Mail. Please excuse my brevity.

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Yugo NAGATA 2023-02-01 08:32:52 Re: Allow an extention to be updated without a script
Previous Message Peter Eisentraut 2023-02-01 07:40:52 meson: pkgconfig difference