meson: pkgconfig difference

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: meson: pkgconfig difference
Date: 2023-02-01 07:40:52
Message-ID: 07b37c70-349a-8fcd-bcc9-6c3ce0f6c2a4@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I think there is a tiny typo in src/interfaces/ecpg/ecpglib/meson.build:

diff --git a/src/interfaces/ecpg/ecpglib/meson.build
b/src/interfaces/ecpg/ecpglib/meson.build
index dba9e3c3d9..da8d304f54 100644
--- a/src/interfaces/ecpg/ecpglib/meson.build
+++ b/src/interfaces/ecpg/ecpglib/meson.build
@@ -57,7 +57,7 @@ pkgconfig.generate(
description: 'PostgreSQL libecpg library',
url: pg_url,
libraries: ecpglib_so,
- libraries_private: [frontend_shlib_code, thread_dep],
+ libraries_private: [frontend_stlib_code, thread_dep],
requires_private: ['libpgtypes', 'libpq'],
)

This makes it match the other libraries.

Without this change, we get

Libs.private: ... -lpgport_shlib -lpgcommon_shlib

which seems wrong.

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2023-02-01 07:55:46 Re: meson: pkgconfig difference
Previous Message Ilya Gladyshev 2023-02-01 07:21:35 Re: Progress report of CREATE INDEX for nested partitioned tables