Re: Possible inaccurate description of wal_compression in docs

From: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
To: Jingtang Zhang <mrdrivingduck(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Possible inaccurate description of wal_compression in docs
Date: 2025-08-11 15:59:55
Message-ID: B1F577F8-3048-487B-B20E-15D2239DBBD3@yandex-team.ru
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 10 Aug 2025, at 13:53, Jingtang Zhang <mrdrivingduck(at)gmail(dot)com> wrote:
>
> Hi hackers~
>
> I find the specification of wal_compression in our docs a little bit confusing
> for it 'compress full page images when FPW is on or during a base backup',
> which was true before v17. Since v17, we will also use full page images for
> creating index or table rewrites through bulk write, so it is inaccurate.
>
> Should we change the doc a little bit: 'compress full page images written
> to WAL, **like** when FPW is on, or during a base backup', if we may use
> FPI in other places in the future?

FPWs are used here and there in a lot of places, like "FPI for hint". And indexes are build using FPI for many years, it did not start with 17...
This list is not exhaustive in any case, so I agree that formulation should not be very strict.

Best regards, Andrey Borodin.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David E. Wheeler 2025-08-11 16:46:29 Re: Generate GUC tables from .dat file
Previous Message Xuneng Zhou 2025-08-11 15:41:23 Re: Possible inaccurate description of wal_compression in docs