Re: Preprocessor condition fix

From: Christian Ullrich <chris(at)chrullrich(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Preprocessor condition fix
Date: 2016-04-12 13:52:10
Message-ID: AM2PR06MB0690AA5BF7D5274597A3FEA4D4950@AM2PR06MB0690.eurprd06.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

* From: Tom Lane [mailto:tgl(at)sss(dot)pgh(dot)pa(dot)us]

> Christian Ullrich <chris(at)chrullrich(dot)net> writes:

> > * Tom Lane wrote:
> >> Hm, my grep found another one ...
>
> > Oh, sorry. I saw that one, but thought it was intentional because _WIN64
> > is defined automatically anyway.
>
> Oh? Then we should not need that one (the /D switch in win32.mak) at all.
> Should we just remove it?

We have both confirmed several times that nothing depends on it. I think it can go.

--
Christian

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Justin Clift 2016-04-12 14:08:03 Re: Lets (not) break all the things. Was: [pgsql-advocacy] 9.6 -> 10.0
Previous Message Tom Lane 2016-04-12 13:49:11 Re: Preprocessor condition fix