| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Sho Ito <i(dot)sho(dot)0628(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH v1] Fix tab completion for concurrent materialized view refresh |
| Date: | 2026-10-25 23:54:48 |
| Message-ID: | ACECA4FB-5BBB-4B75-87AB-C29D3378C568@yesql.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 13 Oct 2026, at 09:59, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
>> On 13 Oct 2026, at 05:54, Sho Ito <i(dot)sho(dot)0628(at)gmail(dot)com> wrote:
>
>> psql currently suggests `WITH NO DATA` for
>> `REFRESH MATERIALIZED VIEW CONCURRENTLY`, although the backend rejects
>> that combination [1].
>
> Good find, that's indeed incorrect.
>
>> The attached patch offers only `DATA` after concurrent `WITH` and removes
>> `DATA` completion after a manually entered concurrent `WITH NO`.
>> Nonconcurrent refresh completion remains unchanged.
>
> Thanks, I will apply this with a backpatch all the way down to 14.
Done, thanks for the patch!
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chao Li | 2026-10-26 00:20:03 | Re: Reject incompatible options specified with VACUUM ONLY_DATABASE_STATS |
| Previous Message | Tomas Vondra | 2026-10-25 23:37:31 | A bug in recovery prefetcher, triggering asserts / FATAL: checkpoint request failed |