Re: [PATCH v1] Fix tab completion for concurrent materialized view refresh

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Sho Ito <i(dot)sho(dot)0628(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH v1] Fix tab completion for concurrent materialized view refresh
Date: 2026-10-13 07:59:26
Message-ID: 1900F7C8-B9C0-4359-9E10-2897DB937562@yesql.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 13 Oct 2026, at 05:54, Sho Ito <i(dot)sho(dot)0628(at)gmail(dot)com> wrote:

> psql currently suggests `WITH NO DATA` for
> `REFRESH MATERIALIZED VIEW CONCURRENTLY`, although the backend rejects
> that combination [1].

Good find, that's indeed incorrect.

> The attached patch offers only `DATA` after concurrent `WITH` and removes
> `DATA` completion after a manually entered concurrent `WITH NO`.
> Nonconcurrent refresh completion remains unchanged.

Thanks, I will apply this with a backpatch all the way down to 14.

--
Daniel Gustafsson

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2026-10-13 08:03:21 Re: [PATCH v2] Fix races in Windows pthread emulation
Previous Message Fujii Masao 2026-10-13 07:54:51 Re: [PG19] psql backslash commands fail with translated messages and a non UTF-8 client encoding