Re: Avoid use deprecated Windows Memory API

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Avoid use deprecated Windows Memory API
Date: 2022-09-15 13:30:13
Message-ID: AC3BDF40-9C88-4FB4-AAC0-FA99C266B3AD@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 15 Sep 2022, at 15:13, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>
> On 2022-Sep-15, Ranier Vilela wrote:
>
>> Em qui., 15 de set. de 2022 às 09:50, Alvaro Herrera <
>> alvherre(at)alvh(dot)no-ip(dot)org> escreveu:
>
>>> These functions you are patching are not in performance-sensitive code,
>>> so I doubt this makes any difference performance wise. I doubt
>>> Microsoft will ever remove these deprecated functions, given its history
>>> of backwards compatibility, so from that perspective this change does
>>> not achieve anything either.
>>
>> If users don't adapt to the new API, the old one will never really expire.
>
> If you are claiming that Microsoft will remove the old API because
> Postgres stopped using it, ... sorry, no.

Also, worth noting is that these functions aren't actually deprecated. The
note in the docs state:

The local functions have greater overhead and provide fewer features
than other memory management functions. New applications should use
the heap functions unless documentation states that a local function
should be used.

And following the bouncing ball into the documentation they refer to [0] I read
this:

As a result, the global and local families of functions are equivalent
and choosing between them is a matter of personal preference.

--
Daniel Gustafsson https://vmware.com/

[0]: https://docs.microsoft.com/en-us/windows/win32/memory/global-and-local-functions

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ranier Vilela 2022-09-15 13:44:05 Re: Avoid use deprecated Windows Memory API
Previous Message Ranier Vilela 2022-09-15 13:29:22 Re: Avoid use deprecated Windows Memory API