Re: [COMMITTERS] pgsql: Add current WAL end (as seen by walsender, ie, GetWriteRecPtr()

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Tom Lane <tgl(at)postgresql(dot)org>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Add current WAL end (as seen by walsender, ie, GetWriteRecPtr()
Date: 2010-06-07 13:35:10
Message-ID: AANLkTinpAE4gBfwag_oODi28uyEXI3qQoZ-lfQ8djToq@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Fri, Jun 4, 2010 at 7:17 AM, Tom Lane <tgl(at)postgresql(dot)org> wrote:
> Log Message:
> -----------
> Add current WAL end (as seen by walsender, ie, GetWriteRecPtr() result)
> and current server clock time to SR data messages.  These are not currently
> used on the slave side but seem likely to be useful in future, and it'd be
> better not to change the SR protocol after release.  Per discussion.
> Also do some minor code review and cleanup on walsender.c, and improve the
> protocol documentation.

This commit changed walsender so that it doesn't call set_ps_display() if
update_process_title = off. On the other hand, walreceiver doesn't check
update_process_title. Though this check might not be required since it's
within set_ps_display(), we should do that for the sake of consistency?
I attached the patch.

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

Attachment Content-Type Size
walrcv_update_process_title_v1.patch application/octet-stream 1.0 KB

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Teodor Sigaev 2010-06-07 15:14:36 pgsql: Add missed function dblink_connect_u(text[, text]) to uninstall
Previous Message Takahiro Itagaki 2010-06-07 03:01:35 pgsql: Ensure default-only storage parameters for TOAST relations to be

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Sabino Mullane 2010-06-07 13:59:59 Re: Invalid YAML output from EXPLAIN
Previous Message Fujii Masao 2010-06-07 13:21:56 warning message in standby