From: | itagaki(at)postgresql(dot)org (Takahiro Itagaki) |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Ensure default-only storage parameters for TOAST relations to be |
Date: | 2010-06-07 03:01:35 |
Message-ID: | 20100607030135.145A37541D2@cvs.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Log Message:
-----------
Ensure default-only storage parameters for TOAST relations
to be initialized with proper values. Affected parameters are
fillfactor, analyze_threshold, and analyze_scale_factor.
Especially uninitialized fillfactor caused inefficient page usage
because we built a StdRdOptions struct in which fillfactor is zero
if any reloption is set for the toast table.
In addition, we disallow toast.autovacuum_analyze_threshold and
toast.autovacuum_analyze_scale_factor because we didn't actually
support them; they are always ignored.
Report by Rumko on pgsql-bugs on 12 May 2010.
Analysis by Tom Lane and Alvaro Herrera. Patch by me.
Backpatch to 8.4.
Tags:
----
REL8_4_STABLE
Modified Files:
--------------
pgsql/doc/src/sgml/ref:
create_table.sgml (r1.114.2.2 -> r1.114.2.3)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/ref/create_table.sgml?r1=1.114.2.2&r2=1.114.2.3)
pgsql/src/backend/access/common:
reloptions.c (r1.28.2.2 -> r1.28.2.3)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/common/reloptions.c?r1=1.28.2.2&r2=1.28.2.3)
From | Date | Subject | |
---|---|---|---|
Next Message | Fujii Masao | 2010-06-07 13:35:10 | Re: [COMMITTERS] pgsql: Add current WAL end (as seen by walsender, ie, GetWriteRecPtr() |
Previous Message | Takahiro Itagaki | 2010-06-07 02:59:02 | pgsql: Ensure default-only storage parameters for TOAST relations to be |