Re: pgAdmin III commit: Somehow forgot to commit this.

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Peter Geoghegan <peter(dot)geoghegan86(at)gmail(dot)com>
Cc: Thom Brown <thom(at)linux(dot)com>, pgadmin-hackers(at)postgresql(dot)org
Subject: Re: pgAdmin III commit: Somehow forgot to commit this.
Date: 2011-02-16 13:41:39
Message-ID: AANLkTinmzWXMmvqOuJXLsdRfjuY-ZiuEC7DTh1qthGVE@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Wed, Feb 16, 2011 at 1:38 PM, Peter Geoghegan
<peter(dot)geoghegan86(at)gmail(dot)com> wrote:
> Oh, okay.
>
> It doesn't actually build against 2.9 yet, due to a lack of this,
> because someone subsequently broke 2.9 compatibility:

That would be me :-p

>  // Handle, and pass up child focus events
>  void ctlAuiNotebook::OnChildFocus(wxChildFocusEvent &event)
>  {
> +
> +#if wxCHECK_VERSION(2, 9, 0)
> +       wxAuiNotebook::OnChildFocusNotebook(event);
> +       GetParent()->GetEventHandler()->AddPendingEvent(event);
> +#else
>        wxAuiNotebook::OnChildFocus(event);
>        GetParent()->AddPendingEvent(event);
> +#endif
> +
>  }
>
> The next patch of mine you commit should be last night's, which is a
> superset of this patch. There will be merge conflicts. Would you like
> me to produce a new patch without merge conflicts for your
> convenience?

That would be helpful - thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Hope Jiang 2011-02-16 14:26:49 pgAdmin III: updated Korean translation
Previous Message Peter Geoghegan 2011-02-16 13:38:57 Re: pgAdmin III commit: Somehow forgot to commit this.