Re: pgAdmin III commit: Somehow forgot to commit this.

From: Peter Geoghegan <peter(dot)geoghegan86(at)gmail(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Thom Brown <thom(at)linux(dot)com>, pgadmin-hackers(at)postgresql(dot)org
Subject: Re: pgAdmin III commit: Somehow forgot to commit this.
Date: 2011-02-16 13:38:57
Message-ID: AANLkTi=fKmcNUXeCot1eG5McO_++d14Ppt6+J38LRCos@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Oh, okay.

It doesn't actually build against 2.9 yet, due to a lack of this,
because someone subsequently broke 2.9 compatibility:

// Handle, and pass up child focus events
void ctlAuiNotebook::OnChildFocus(wxChildFocusEvent &event)
{
+
+#if wxCHECK_VERSION(2, 9, 0)
+ wxAuiNotebook::OnChildFocusNotebook(event);
+ GetParent()->GetEventHandler()->AddPendingEvent(event);
+#else
wxAuiNotebook::OnChildFocus(event);
GetParent()->AddPendingEvent(event);
+#endif
+
}

The next patch of mine you commit should be last night's, which is a
superset of this patch. There will be merge conflicts. Would you like
me to produce a new patch without merge conflicts for your
convenience?

--
Regards,
Peter Geoghegan

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2011-02-16 13:41:39 Re: pgAdmin III commit: Somehow forgot to commit this.
Previous Message Dave Page 2011-02-16 13:28:54 Re: pgAdmin III commit: Somehow forgot to commit this.