Re: pgAdmin III commit: Pull keywords dynamically from PostgreSQL headers

Hi,

since this patch is applied, i can't build
pgAdmin. %pgdir%\include\server\parser doesn't contain a gram.h file.
What I'm doing wrong?

Ty
Jasmin

2011/1/5 Magnus Hagander <magnus(at)hagander(dot)net>

> On Wed, Jan 5, 2011 at 06:05, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>wrote:
>
>>
>>
>> On Wed, Jan 5, 2011 at 12:37 AM, Magnus Hagander <magnus(at)hagander(dot)net>wrote:
>>
>>> On Tue, Jan 4, 2011 at 18:46, Ashesh Vashi <
>>> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Magnus/Dave,
>>>>
>>>> This check-in has added one compilation error.
>>>> The following line introduce an error in file '*pgadmin/db/keywords.c*'
>>>> *#include <server/parser/gram.h>
>>>> #include <server/parser/kwlist.h>*
>>>>
>>>> Because - these header files does not always find under *`pg_config
>>>> --includedir`* folder, but can be found under *`pg_config
>>>> --pkgincludedir`*.
>>>>
>>>> Please find the patch to resolve the issue. This applies on both master
>>>> and REL-1_12_PATCHES branch.
>>>>
>>>>
>>> Looks good in general, but do we actually need to put it on 1.12? The
>>> keyword build changes were only applied to master, so unless we actually
>>> *need* it on the back branch, I don't think we should put it there. Is it
>>> needed for something else as well?
>>>
>> You're right.
>> This patch should only be applied on master.
>>
>
> Thanks, confirmed and applied.
>
>
> --
> Magnus Hagander
> Me: http://www.hagander.net/
> Work: http://www.redpill-linpro.com/
>