Re: [COMMITTERS] pgsql: Still more tweaking of git_changelog.

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Still more tweaking of git_changelog.
Date: 2010-09-26 21:11:17
Message-ID: AANLkTingYQtoTg8Angnt8FMZoBoH=QJDWskyGJZwAvBG@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Sun, Sep 26, 2010 at 4:38 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I wrote:
>> We could perhaps fix that if there were an inexpensive way to get the
>> SHA1 of the master commit that each branch is sprouted from.  However,
>> I'm inclined to propose that we instead manually place a tag at each
>> sprout point.
>
> Hah, I have a plan.  Let's just run git log for "master..RELx_y_STABLE"
> for each branch, rather than all the way back.  Then we can identify the
> sprout point as the parent of the last emitted commit for the branch.
> The "post dated" or "double tagged" or whatever you call 'em branch
> annotations for earlier master commits can then be inserted by hand,
> rather than reverse-engineering them by matching author/message/etc.
> This should be both faster and more reliable than the current method.

This doesn't seem more reliable to me in any way. Looking at the
actual commit history must surely be more reliable than assuming you
know what it is. I think what you should be doing is using git log
--decorate and extracting the information from that as you go by.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2010-09-27 00:22:35 pgsql: Improve git_changelog as per discussion with Robert Haas.
Previous Message Tom Lane 2010-09-26 20:38:23 Re: [COMMITTERS] pgsql: Still more tweaking of git_changelog.

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2010-09-26 21:13:17 Re: do we want to gitignore regression-test-failure files?
Previous Message Tom Lane 2010-09-26 20:38:23 Re: [COMMITTERS] pgsql: Still more tweaking of git_changelog.