Re: do we want to gitignore regression-test-failure files?

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: do we want to gitignore regression-test-failure files?
Date: 2010-09-26 21:13:17
Message-ID: AANLkTi=nQOAEdTyZhSS2FNzvkTqAmKqaAL5S7L=4RfhM@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Sep 26, 2010 at 4:28 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> The reason I assumed we'd want to ignore these is because they're
>> automatically generated files - unlike *.rej files, which are never
>> going to end up in your tree as a result of make anything.  It doesn't
>> actually matter that much to me in practice, except that I fear
>> creating a complex and indecipherable rule about what to ignore vs.
>> not.
>
> I don't find it indecipherable.  We're ignoring stuff that can be
> expected to be present after a normal build and successful "make
> check" or "make installcheck".  As soon as we ignore more than that,
> I'm going to insist on ignoring *~ ... do you want to open that can
> of worms?

What is this, some kind of game of chicken? Surely we're trying to
settle on a sensible rule here, not get into a mud-wrestling match. I
can live with the rule you've articulated but I think it's more
complicated than necessary, and I certainly don't want to see it
further complicated. Let's get it written down in a README file
someplace and not be moving the goalposts henceforth.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Thom Brown 2010-09-26 21:56:34 recovery.conf location
Previous Message Robert Haas 2010-09-26 21:11:17 Re: [COMMITTERS] pgsql: Still more tweaking of git_changelog.