Re: Adding xpath_exists function

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: mike(at)mlfowler(dot)com
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Adding xpath_exists function
Date: 2010-05-07 02:40:59
Message-ID: AANLkTindcyMH87hwvFH-cLwRNMCdsMbDPCrxdqg-Lj_g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-rrreviewers

On Thu, May 6, 2010 at 5:53 PM, <mike(at)mlfowler(dot)com> wrote:
> Quoting Robert Haas <robertmhaas(at)gmail(dot)com>:
>
>>
>> I'm not sure I understand how this more convenient than just using
>> xpath() with exists()?
>>
>
> It will save a lot of complexity in WHERE clauses. For example using
> exists() in xpath() you might construct something like:
>
> WHERE array_dims(xpath('exists(/foo/bar)','<bar><foo/></bar>'::xml) IS NOT
> NULL ...
>
> Whereas a dedicated xpath_exists() would look like:
>
> WHERE xpath_exists('/foo/bar','<bar><foo/></bar>'::xml) ....
>
> I accept this example is quite basic, but I hope it illustrates the added
> usability. I think xml in sql is complex enough, especially when you start
> considering namespaces, that anything we can do to simplify common use cases
> can only help improve the uptake of postgres xml.

Oh, I see. Well, that might be reasonable syntactic sugar, although I
think you should make it wrap the path in exists() unconditionally,
rather than testing for an existing wrap.

Please email your patch to the list (replying to this email is fine)
and add it here:
https://commitfest.postgresql.org/action/commitfest_view/open

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2010-05-07 03:24:51 Re: including PID or backend ID in relpath of temp rels
Previous Message Takahiro Itagaki 2010-05-07 02:19:33 Re: pg_stat_transaction patch

Browse pgsql-rrreviewers by date

  From Date Subject
Next Message Mike Fowler 2010-05-07 09:46:55 Re: Adding xpath_exists function
Previous Message mike 2010-05-06 21:53:23 Re: Adding xpath_exists function