| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: WIP: extensible enums |
| Date: | 2010-10-13 06:08:56 |
| Message-ID: | AANLkTin3FXrSBcxLN+4F+LZ=Mo4o=cX-jwf4kdprYw4s@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Oct 1, 2010 at 7:12 AM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> On 10/01/2010 04:35 AM, Dean Rasheed wrote:
>>
>> 2). In enum_ccmp(), when you cache the full list of elements, you're
>> not updating mycache->sort_list_length, so it will keep fetching the
>> full list each time. Also, I think that function could use a few more
>> comments.
>
> Good catch. Will fix.
>
>> 3). I think you need to update psql so that \dT+ returns the enum
>> elements in the right order.
>
> Yeah. Will do.
>
> I will post a revised patch soon.
Should we postpone this to the next CommitFest?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2010-10-13 06:13:30 | Re: security hook on authorization |
| Previous Message | Robert Haas | 2010-10-13 05:49:27 | Re: levenshtein_less_equal (was: multibyte charater set in levenshtein function) |