From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: WIP: extensible enums |
Date: | 2010-10-13 11:33:58 |
Message-ID: | 4CB59926.7050108@dunslane.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 10/13/2010 02:08 AM, Robert Haas wrote:
> On Fri, Oct 1, 2010 at 7:12 AM, Andrew Dunstan<andrew(at)dunslane(dot)net> wrote:
>> On 10/01/2010 04:35 AM, Dean Rasheed wrote:
>>> 2). In enum_ccmp(), when you cache the full list of elements, you're
>>> not updating mycache->sort_list_length, so it will keep fetching the
>>> full list each time. Also, I think that function could use a few more
>>> comments.
>> Good catch. Will fix.
>>
>>> 3). I think you need to update psql so that \dT+ returns the enum
>>> elements in the right order.
>> Yeah. Will do.
>>
>> I will post a revised patch soon.
> Should we postpone this to the next CommitFest?
Sorry, got distracted. Here's a new patch that fixes the above and also
contains some documentation.
cheers
andrew
Attachment | Content-Type | Size |
---|---|---|
venum4.patch | text/x-patch | 117.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Craig Ringer | 2010-10-13 11:42:00 | Re: Slow count(*) again... |
Previous Message | Pavel Stehule | 2010-10-13 10:56:06 | Re: wip: functions median and percentile |