pgAdmin III: the debugger does not pre-populate default values for arguments

From: Nikhil S <nixmisc(at)gmail(dot)com>
To: pgadmin-hackers(at)postgresql(dot)org
Subject: pgAdmin III: the debugger does not pre-populate default values for arguments
Date: 2011-02-07 08:03:02
Message-ID: AANLkTimSxLtpz-JnxuQMSaee2ZqxwPLPUWHdvXnJ+r-1@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

The debugger, when it is invoked on a function or a procedure, provides a
dialogue box to fill up values for the arguments. In case the user has
created them with some default values assigned to some of the parameters,
then they would expect that the debugger pre-populates them with those
default values. This is not happening currently.

The attached patch provides this functionality.

We check if the "argdefvals" column exists in the output for the func/proc.
If it does, it gets tokenized and added to the corresponding wsArgInfo
object. These values then get displayed appropriately.

One side-effect of this feature is that earlier where non-default variables
appeared as empty, they will now appear with values "". This will happen
only if some arguments have defvals and some don't. We could have added code
to do away with "" entries, but then I thought it is possible for people to
provide "" as default values too. So we can live with this I think..

Regards,
Nikhils

Attachment Content-Type Size
pgadmin3_add_defvals_debugger.patch text/x-diff 3.7 KB

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2011-02-07 08:57:13 Re: Hiding Schedules/Step tabs while creating a new pgAgent job
Previous Message Nikhil S 2011-02-07 06:45:01 Re: Hiding Schedules/Step tabs while creating a new pgAgent job